Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new adapter for Appier bidder. #3370

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Conversation

PCMan-Appier
Copy link
Contributor

Type of change

  • [x ] New bidder adapter

Description of change

Added a new bidder adapter for Appier.

  • code: modules/appierBidAdapter.js
  • doc: modules/appierBidAdapter.md
  • unit test: test/spec/modules/appierBidAdapter_spec.js
  • test parameters for validating bids
var adUnits = [{
    code: '/5044416/300x250_appier_prebid',  // DFP ad unit id
    mediaTypes: {
        banner: {sizes: [[300, 250]]}
    },
    bids: [{
        bidder: 'appier',
        params: {
            hzid: 'WhM5WIOp'   // appier hzid of the zone
        }
    }]
}];

pbjs.que.push(function() {
    pbjs.setConfig({
        appier: {
            'server': 'twgce-pmp-server-stg.apx.appier.net'
        }
    });
});

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer: apn-dev@appier.com
  • [x ] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

* @return {Bid[]} An array of bids which were nested inside the server.
*/
interpretResponse: function (serverResponse, serverRequest) {
if (!serverResponse.body || !Array.isArray(serverResponse.body)) {
Copy link
Contributor

@idettman idettman Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can optimize this conditional and it will behave the same:

if (!Array.isArray(serverResponse.body)) {
  return []
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idettman I did the requested change and did git squash.
Thanks for the prompt review and the suggestions!

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for the small fix mentioned on line #64, once this is fixed I'll approve

@PCMan-Appier
Copy link
Contributor Author

@idettman BTW, once approved, when will this be released and available from the download menu on Prebid.js official website? I mean this: http://prebid.org/download.html
Thank you.

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit 32a611d into prebid:master Dec 14, 2018
loic-talon pushed a commit to onfocusio/Prebid.js that referenced this pull request Dec 19, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants